Skip to content

Conversation

theodkp
Copy link
Contributor

@theodkp theodkp commented Sep 10, 2025

Windows Download button now downloads file and opens a modal which contains instructions and video demonstration

Added new on-download modal
Added shadcn dialog ui component
Bumped @radix-ui/react-dialog to ^1.1.15

closes #61

@theodkp theodkp requested a review from konsalex as a code owner September 10, 2025 19:40
Copy link

netlify bot commented Sep 10, 2025

Deploy Preview for hoppdocs ready!

Name Link
🔨 Latest commit 934ae54
🔍 Latest deploy log https://app.netlify.com/projects/hoppdocs/deploys/68c1f5e81d78b70008e07534
😎 Deploy Preview https://deploy-preview-80--hoppdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@konsalex konsalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @theodkp thanks so much for putting the work and even creating a video for this, amazing work 🙏

Two minor comments.

As we are serving a single compiled HTML file, could you use this URL instead of loading the video: https://dlh49gjxx49i3.cloudfront.net/web-app/wmv3.mp4

Currently this is not streamlined, but to update the static assets we serve you could generated them after you make the changes with task webapp:build-prod && webapp:inject-to-backend

@theodkp
Copy link
Contributor Author

theodkp commented Sep 10, 2025

@konsalex Made the changes to url and built static files with task webapp:build-prod && webapp:inject-to-backend. let me know if anything went wrong with the build!!

@konsalex konsalex merged commit 093d261 into gethopp:main Sep 10, 2025
14 checks passed
@konsalex
Copy link
Contributor

@theodkp Thanks for the contribution, looking forward for the next ones

@konsalex konsalex changed the title Design: Added Temporary missing windows license modal design: Added Temporary missing windows license modal Sep 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

design: create a smooth experience for missing windows license

2 participants