Skip to content

Conversation

shree-xvi
Copy link

  • Add comprehensive list of 700+ disposable email domains
  • Implement smart email validation with subdomain detection
  • Add configurable blocking via BLOCK_DISPOSABLE_EMAILS env var
  • Add strict mode for business-only domains via EMAIL_STRICT_MODE env var
  • Integrate validation into manual signup and social auth flows
  • Provide user-friendly error messages with helpful suggestions
  • Include comprehensive test suite with benchmarks
  • Add detailed documentation and configuration examples

This feature helps maintain user quality by blocking temporary/throwaway email addresses while providing clear guidance to users on alternatives.

…on noise

- Add comprehensive list of 700+ disposable email domains
- Implement smart email validation with subdomain detection
- Add configurable blocking via BLOCK_DISPOSABLE_EMAILS env var
- Add strict mode for business-only domains via EMAIL_STRICT_MODE env var
- Integrate validation into manual signup and social auth flows
- Provide user-friendly error messages with helpful suggestions
- Include comprehensive test suite with benchmarks
- Add detailed documentation and configuration examples

This feature helps maintain user quality by blocking temporary/throwaway
email addresses while providing clear guidance to users on alternatives.
@shree-xvi shree-xvi requested a review from konsalex as a code owner September 9, 2025 07:21
@CLAassistant
Copy link

CLAassistant commented Sep 9, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Sep 9, 2025

Deploy Preview for hoppdocs ready!

Name Link
🔨 Latest commit 0687372
🔍 Latest deploy log https://app.netlify.com/projects/hoppdocs/deploys/68bfd56cbdea950008ee2e1e
😎 Deploy Preview https://deploy-preview-75--hoppdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@konsalex konsalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @shree-xvi 🙏 Some points to make this PR mergable.

  1. The domain list is quite arbitrarily generated, so it will be hard to maintain without any fetching/syncing step with a remote source in the long run. I would simplify the implementation a lot by going with a library like this one lindell/go-burner-email-providers as they have a maintained list, and currently contain 27.280 domains. The libs' API is also super easy to use.

  2. Readme for this feature is not needed.

  3. You can also add the BLOCK_DISPOSABLE_EMAILS in our env file here hopp/backend/env-files/.env.local at main · gethopp/hopp with what the default value should be.

@konsalex
Copy link
Contributor

konsalex commented Oct 5, 2025

Closing in favour of #116

@konsalex konsalex closed this Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants