feat: remove team member #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for hoppdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
konsalex
reviewed
Oct 11, 2025
backend/internal/email/email.go
Outdated
Comment on lines
128
to
131
| htmlBody := string(templateBytes) | ||
| htmlBody = strings.Replace(htmlBody, "{first_name}", user.FirstName, -1) | ||
| htmlBody = strings.Replace(htmlBody, "{old_team_name}", oldTeamName, -1) | ||
| htmlBody = strings.Replace(htmlBody, "{new_team_name}", newTeamName, -1) |
There was a problem hiding this comment.
nit: Recently I learned this is a good use case for strings.Replacer
backend/internal/email/email.go
Outdated
| htmlBody = strings.Replace(htmlBody, "{old_team_name}", oldTeamName, -1) | ||
| htmlBody = strings.Replace(htmlBody, "{new_team_name}", newTeamName, -1) | ||
|
|
||
| subject := fmt.Sprintf("You've been removed from %s", oldTeamName) |
There was a problem hiding this comment.
We could prefix the subject line with Hopp so folks will know who this message comes from immediately
Comment on lines
+894
to
+896
| if !user.IsAdmin { | ||
| return echo.NewHTTPError(http.StatusForbidden, "admin required") | ||
| } |
There was a problem hiding this comment.
nit: those checks are preferable to be highest priority, as you avoid doing any roundtrips to the DB. Fail fast type of thing.
konsalex
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
closes #135