Skip to content

Conversation

K20shores
Copy link
Contributor

@K20shores K20shores commented Sep 20, 2024

Name and Institution (Required)

Name: Kyle Shores
Institution: NCAR

Describe the update

  • Adds a github actions test that builds on windows.
  • Adds a test which runs CloudJ against known output

Expected changes

None.

Reference(s)

Related Github Issues and PRs

@lizziel
Copy link
Contributor

lizziel commented Sep 30, 2024

Thanks @K20shores. I can bring this in into the next version. I kept around the netcdf support just in case we want to read data as netcdf in the future. For example, there's a climatology file read for standalone that is currently ascii but it could easily be netcdf instead. This is not essential, however, and we can bring back netcdf support at the time we want to add it.

@K20shores
Copy link
Contributor Author

@lizziel we figured out how to build TUVx on windows while including netcdf (NCAR/tuv-x#112). Would you like me to rollback the changes that remove netcdf?

@lizziel
Copy link
Contributor

lizziel commented Nov 12, 2024

@K20shores, yes, if there is no need to delete then let's keep it in there.

@K20shores
Copy link
Contributor Author

@lizziel done. The changes look much smaller now that netcdf has been put back

CHANGELOG.md Outdated
- Tests which compare the output of Cloud-J to some saved reference output.

### Changed
- The try_compile.f90 file no longer tries to use netcdf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change still true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is not. Fixed!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

stale bot commented Jan 31, 2025

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the stale label Jan 31, 2025
@lizziel lizziel changed the base branch from main to dev/8.0.2 February 3, 2025 15:29
@lizziel lizziel merged commit 0d103d4 into geoschem:dev/8.0.2 Feb 3, 2025
14 checks passed
@lizziel lizziel added this to the 8.0.1 milestone Mar 10, 2025
@lizziel lizziel modified the milestones: 8.0.1, 8.0.2 Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants