-
Notifications
You must be signed in to change notification settings - Fork 7
Add Windows CI test and setup regression tests against known output #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @K20shores. I can bring this in into the next version. I kept around the netcdf support just in case we want to read data as netcdf in the future. For example, there's a climatology file read for standalone that is currently ascii but it could easily be netcdf instead. This is not essential, however, and we can bring back netcdf support at the time we want to add it. |
@lizziel we figured out how to build TUVx on windows while including netcdf (NCAR/tuv-x#112). Would you like me to rollback the changes that remove netcdf? |
@K20shores, yes, if there is no need to delete then let's keep it in there. |
@lizziel done. The changes look much smaller now that netcdf has been put back |
CHANGELOG.md
Outdated
- Tests which compare the output of Cloud-J to some saved reference output. | ||
|
||
### Changed | ||
- The try_compile.f90 file no longer tries to use netcdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change still true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not. Fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue. |
Name and Institution (Required)
Name: Kyle Shores
Institution: NCAR
Describe the update
Expected changes
None.
Reference(s)
Related Github Issues and PRs