update CoverageJSON compliance #2012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkralidis
added
bug
tomkralidis
force-pushed
the
covjson-updates
branch
from
e4a5093 to
ba279b8
Compare
webb-ben
reviewed
May 13, 2025
Comment on lines
+339
to
+348
| 'values': [float(data.coords[self.x_field].values)] | ||
| } | ||
| cj['domain']['axes']['y'] = { | ||
| 'values': [float(data.coords[self.y_field].values)] | ||
| } | ||
| cj['domain']['domainType'] = 'PointSeries' | ||
|
|
||
| if self.time_field is not None: | ||
| mint, maxt = metadata['time'] | ||
| cj['domain']['axes'][self.time_field] = { | ||
| 'start': mint, | ||
| 'stop': maxt, | ||
| 'num': metadata['time_steps'], | ||
| cj['domain']['axes']['t'] = { | ||
| 'values': [str(v) for v in data[self.time_field].values] |
There was a problem hiding this comment.
Consider using vectorized type casting
| @@ -1425,6 +1425,8 @@ def get_collection_schema(api: API, request: Union[APIRequest, Any], | |||
|
|
|||
| for k, v in p.fields.items(): | |||
| schema['properties'][k] = v | |||
| if v['type'] == 'float': | |||
There was a problem hiding this comment.
Maybe add a comment on why we are setting the schema different than the value returned from the provider.
webb-ben
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates CoverageJSON output in support of compliance.
Related Issue / discussion
None
Additional information
Supercedes #2005 (thanks @adanb13)
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)