Skip to content

DOC/TST: document and test read_dataframe with on_invalid=fix #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

theroggy
Copy link
Member

@theroggy theroggy commented Apr 10, 2025

Document and test the extra option "fix" for the on_invalid parameter of read_dataframe made possible in shapely 2.1.

resolves #423

@theroggy theroggy added this to the 0.11.0 milestone Apr 10, 2025
@theroggy theroggy self-assigned this Apr 10, 2025
@theroggy theroggy changed the title DOC: document read_dataframe on_invalid=fix parameter value DOC/TST: document and test read_dataframe on_invalid=fix parameter value Apr 12, 2025
@theroggy theroggy marked this pull request as ready for review April 12, 2025 08:26
@theroggy theroggy changed the title DOC/TST: document and test read_dataframe on_invalid=fix parameter value DOC/TST: document and test read_dataframe on_invalid=fix Apr 12, 2025
@theroggy theroggy changed the title DOC/TST: document and test read_dataframe on_invalid=fix DOC/TST: document and test read_dataframe with on_invalid=fix Apr 12, 2025
Copy link
Member

@brendan-ward brendan-ward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @theroggy

(please resolve conflict then this is ready to merge)

@theroggy theroggy merged commit 78b74b2 into geopandas:main Apr 14, 2025
25 checks passed
@theroggy theroggy deleted the DOC-document-read_dataframe-on_invalid=fix-parameter-value branch April 14, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: add "repair" and/or "salvage" option to on_invalid parameter in read_dataframe
2 participants