-
-
Notifications
You must be signed in to change notification settings - Fork 27
BLD/RLS: Update wheels to include GDAL 3.9.2 and add manylinux_2_28 wheels #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3b6294d
Add GDAL 3.9.2, libkml, and uv for virtualenv in CI
brendan-ward 0613f12
Try custom port for minizip 1.2.5.2 to match zlib
brendan-ward 27c2107
Rework on top of minizip 1.3.1#1 port
brendan-ward d4dd204
Strip out likely unused patch
brendan-ward cb007fb
Drop attempt to build libkml on manylinux2014
brendan-ward 4bdc4c7
Add build with manylinux_2_28_x86_64 and stop using port of zlib for …
brendan-ward 376e8c5
Remove unused patch
brendan-ward 2b886fa
Try enabling cache of deps, uv run python
brendan-ward ad2b5b9
Try without env vars
brendan-ward 5922cbb
Use uv run elsewhere, add back env vars
brendan-ward 87b9020
Fix install order and prevent geopandas from installing deps
brendan-ward File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
FROM quay.io/pypa/manylinux_2_28_x86_64:2024-08-12-7fde9b1 | ||
|
||
# building openssl needs IPC-Cmd (https://github.com/microsoft/vcpkg/issues/24988) | ||
RUN dnf -y install curl zip unzip tar ninja-build perl-IPC-Cmd | ||
|
||
RUN git clone https://github.com/Microsoft/vcpkg.git /opt/vcpkg && \ | ||
git -C /opt/vcpkg checkout 73794ce5f63fd138fab999a22959ca7c6305d93c | ||
|
||
ENV VCPKG_INSTALLATION_ROOT="/opt/vcpkg" | ||
ENV PATH="${PATH}:/opt/vcpkg" | ||
|
||
ENV VCPKG_DEFAULT_TRIPLET="x64-linux-dynamic-release" | ||
|
||
# mkdir & touch -> workaround for https://github.com/microsoft/vcpkg/issues/27786 | ||
RUN bootstrap-vcpkg.sh && \ | ||
mkdir -p /root/.vcpkg/ $HOME/.vcpkg && \ | ||
touch /root/.vcpkg/vcpkg.path.txt $HOME/.vcpkg/vcpkg.path.txt && \ | ||
vcpkg integrate install && \ | ||
vcpkg integrate bash | ||
|
||
COPY ci/custom-triplets/x64-linux-dynamic-release.cmake opt/vcpkg/custom-triplets/x64-linux-dynamic-release.cmake | ||
COPY ci/vcpkg.json opt/vcpkg/ | ||
|
||
ENV LD_LIBRARY_PATH="${LD_LIBRARY_PATH}:/opt/vcpkg/installed/x64-linux-dynamic-release/lib" | ||
RUN vcpkg install --overlay-triplets=opt/vcpkg/custom-triplets \ | ||
--feature-flags="versions,manifests" \ | ||
--x-manifest-root=opt/vcpkg \ | ||
--x-install-root=opt/vcpkg/installed && \ | ||
vcpkg list | ||
|
||
# setting git safe directory is required for properly building wheels when | ||
# git >= 2.35.3 | ||
RUN git config --global --add safe.directory "*" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
{ | ||
"name": "pyogrio", | ||
"version": "0.8.0", | ||
"version": "0.10.0", | ||
"dependencies": [ | ||
{ | ||
"name": "gdal", | ||
"default-features": false, | ||
"features": ["recommended-features", "curl", "geos", "iconv"] | ||
} | ||
], | ||
"builtin-baseline": "4f4a1821b2e8c7a2863e4df65a4d514f84144049" | ||
"builtin-baseline": "73794ce5f63fd138fab999a22959ca7c6305d93c" | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too important (this way is fine as well), but I think the
uv run python -m pytest ..
should work here, because we are not in the root directory with a pyproject.toml file because of thecd ..
(in contrast to the docker tests, I suppose)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worked fine, but we still need to set the environment variables to automatically activate
uv
, so it doesn't obviate the need for those.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that it matters too much, but just because I wanted to try to understand
uv
better (new to it), I think what is going on:the reason we need to set the env variables (the reason uv does not find the venv automatically) is probably because of the
cd ..
. From theuv run
docs:so because of the
cd ..
the venv directory is actually in a directory down, and not in the current or parent directory.We need the
cd ..
in this case to have the tests run properly on the installed package, but in case we didn't and wanted to runuv
from the root without considering it as a project, that might work by putting a[tool.uv] managed = false
in the pyproject.toml