Skip to content

BUG: fix index in spatial partitions #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2025
Merged

BUG: fix index in spatial partitions #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8f98ea
BUG: fix index in spatial partitions
martinfleis Jun 2, 2025
f46984a
make sure CI is actually red when failling
martinfleis Jun 2, 2025
5f5f38f
changelog
martinfleis Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ jobs:
defaults:
run:
shell: bash -l {0}
continue-on-error: true
strategy:
matrix:
os: [ubuntu-latest]
Expand Down
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,11 @@ Version 0.5.0 (upcoming)

Deprecations and compatibility notes:

- The deprecated `geom_almost_equals` method has been removed. Use `geom_equals_exact` instead.
- The deprecated `geom_almost_equals` method has been removed. Use `geom_equals_exact` instead (#326).

Bug fixes:

- Fixed index in spatial partitions (#329).


Version 0.4.3 (January, 2025)
Expand Down
2 changes: 1 addition & 1 deletion dask_geopandas/expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ def calculate_spatial_partitions(self):
)
).compute(),
crs=self.crs,
)
).reset_index(drop=True)
self.spatial_partitions = parts

def _propagate_spatial_partitions(self, new_object):
Expand Down
5 changes: 4 additions & 1 deletion dask_geopandas/tests/io/test_arrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,10 @@ def test_roundtrip(tmp_path, naturalearth_lowres):
assert_geodataframe_equal(result_gpd, df)
# reading back also populates the spatial partitioning property
ddf.calculate_spatial_partitions()
assert_geoseries_equal(result.spatial_partitions, ddf.spatial_partitions.envelope)
assert_geoseries_equal(
result.spatial_partitions,
ddf.spatial_partitions.envelope,
)


def test_roundtrip_s3(s3_resource, s3_storage_options, naturalearth_lowres):
Expand Down
Loading