Skip to content

Cleanup CI configuring composer's minimum-stability #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,10 +93,6 @@ jobs:
tools: flex
coverage: none

- name: Configure minimum stability
if: matrix.sf_version == '7.3'
run: composer config minimum-stability beta

- name: "Install Composer dependencies"
env:
SYMFONY_REQUIRE: ${{ matrix.sf_version }}
Expand Down
2 changes: 1 addition & 1 deletion src/ProviderFactory/PluginProviderFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ final class PluginProviderFactory
* @param Plugin[] $plugins
* @param ProviderFactoryInterface|callable $factory
* @param array<mixed, mixed> $config config to the client factory
* @param array<mixed, mixed> $pluginProviderOptions config forwarded to the PluginProvider
* @param array{max_restarts?: int<0, max>} $pluginProviderOptions config forwarded to the PluginProvider
*/
public static function createPluginProvider(array $plugins, $factory, array $config, array $pluginProviderOptions = []): PluginProvider
{
Expand Down
1 change: 1 addition & 0 deletions tests/baseline-ignore
Original file line number Diff line number Diff line change
Expand Up @@ -82,3 +82,4 @@
%Geocoder\\Model\\Address::__construct\(\): Implicitly marking parameter \$timezone as nullable is deprecated, the explicit nullable type must be used instead%
%Geocoder\\ProviderAggregator::__construct\(\): Implicitly marking parameter \$decider as nullable is deprecated, the explicit nullable type must be used instead%
%Since symfony/var-exporter 7.3: The "Symfony\\Component\\VarExporter\\LazyGhostTrait" trait is deprecated, use native lazy objects instead.%
%Method "Http\\Promise\\Promise::wait\(\)" might add " Resolved value, null if \$unwrap is set to false" as a native return type declaration in the future. Do the same in implementation "Geocoder\\Plugin\\Promise\\GeocoderFulfilledPromise" now to avoid errors or add an explicit @return annotation to suppress this message.%