Speedup archetype changes #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code done by ElectroJr not me, I just PRd it.
# Conflicts: # src/Arch.Benchmarks/Benchmark.cs # src/Arch/Core/Archetype.cs
Optimisation.
Rather than doing GetType on every component array we can just pass in the Signature to check the componenttype from the archetype.
# Conflicts: # src/Arch.Benchmarks/Benchmark.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon work in #232 and #266
The former code is required (specifically Electro implementing TryIndex) and the latter was mostly to get the complete suite of Add / Remove changes to compare against.
Old benchmark:
New benchmark:
Hopefully I haven't cooked the copy but I'm trusting tests would catch anything.