-
Notifications
You must be signed in to change notification settings - Fork 0
Add probabilistic modeling API with model factory and runner #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2025
This was referenced May 27, 2025
Relocated `change_backend_gempy` call to `run_gempy_forward` to ensure proper backend configuration during execution. Removed redundant imports to clean up the module.
Refactored the code to define and utilize the `GemPyPyroModel` type alias for improved type clarity across the codebase. Updated method signatures and relevant imports to align with the new type definition.
Introduces `run_predictive` in the API for running predictive sampling. Refactored existing code in `test_prob_factory` to use the new utility, enhancing modularity and reducing redundancy.
32e5a0d
to
619caaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probabilistic Modeling Framework for GemPy
This PR introduces a comprehensive framework for probabilistic modeling in GemPy, making it easier to define, run, and analyze probabilistic geological models.
Key Features
make_gempy_pyro_model
to create Pyro models for GemPy with clean separation of concernsGemPyPyroModel
type alias for better type clarity throughout the codebaserun_predictive
,run_nuts_inference
, andrun_mcmc_for_NUTS
NUTSConfig
dataclassImplementation Details
run_gempy_forward
for consistent executionThis PR lays the groundwork for more sophisticated probabilistic modeling in GemPy, making it easier for users to define custom models while maintaining a clean separation between model definition, execution, and analysis.