Skip to content

Editor for calparams #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2025
Merged

Editor for calparams #1094

merged 3 commits into from
Oct 23, 2025
+1,211 −303

Conversation

hugo-vrijswijk
Copy link
Contributor

@hugo-vrijswijk hugo-vrijswijk commented Oct 23, 2025 •
edited
Loading

  • New table in configs db for calparams, including createdAt for history
  • Separates out CommentConfirmButton to reuse
  • Modal in UI to view/edit calparams
  • Show which params are under construction with tooltip
  • No revert functionality yet, but UI shows button for future use

@hugo-vrijswijk hugo-vrijswijk force-pushed the sc-6745-navigate-editor-for-calparams branch from f72ed96 to 05d611a Compare October 23, 2025 13:45
@hugo-vrijswijk hugo-vrijswijk force-pushed the sc-6745-navigate-editor-for-calparams branch from 05d611a to ef7f264 Compare October 23, 2025 13:52
@hugo-vrijswijk hugo-vrijswijk changed the title sc 6745 navigate editor for calparams Editor for calparams Oct 23, 2025
@hugo-vrijswijk hugo-vrijswijk force-pushed the sc-6745-navigate-editor-for-calparams branch from ef7f264 to 26b8945 Compare October 23, 2025 14:05
@bundlemon
Copy link

bundlemon bot commented Oct 23, 2025 •
edited
Loading

BundleMon

Files updated (3)
Status Path Size Limits
✅ assets/index-(hash).js
 569.07KB (+6.53KB +1.16%) -
✅ assets/prime-(hash).js
 164.47KB (+982B +0.59%) -
✅ assets/index-(hash).css
 47.06KB (+147B +0.31%) -

Total files change +7.63KB +0.99%

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

dngomez
dngomez reviewed Oct 23, 2025
View reviewed changes
packages/configs/src/graphql/schema/WindowCenter.graphql
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know using @deprecated was an option. So handy!

@hugo-vrijswijk hugo-vrijswijk force-pushed the sc-6745-navigate-editor-for-calparams branch from 26b8945 to 4a47ad2 Compare October 23, 2025 14:30
dngomez
dngomez approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@dngomez dngomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hugo-vrijswijk hugo-vrijswijk merged commit 6064712 into main Oct 23, 2025
10 checks passed
@hugo-vrijswijk hugo-vrijswijk deleted the sc-6745-navigate-editor-for-calparams branch October 23, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dngomez dngomez dngomez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hugo-vrijswijk @dngomez