Fallback configuration if does not exist #1036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles updated (1)
Unchanged files (2)
Total files change +47B +0.01% Final result: ✅ View report in BundleMon website ➡️ |
packages/ui/src/components/Panels/Telescope/Systems/Instrument.tsx
Outdated
Show resolved
Hide resolved
…ck-instrument-configuration
hugo-vrijswijk
deleted the
sc-6925-create-fallback-instrument-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the instrument resolver, so every time a configuration is not found, it will try to get the configuration related to the same instrument but using
wfs: NONEand create a copy using the requested wfs, the new configuration will have a comment which will be displayed using a toast in the UI to warn the client.If nothing is found, then an default configuration using default values (0.0 or false in most of them) and the same toast will warn the user with a different message.
Currently if no configuration is found the system doesn't know what to do and it is necessary to manually connect to the database and create a configuration.