Create telluric system groups #2050
Open
+1,054
−562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions. Initial logic for f2 tellurics
cquiroz
changed the title
swalker2m
reviewed
Oct 16, 2025
| fpu: Flamingos2Fpu | ||
| ) extends CalibrationConfigSubset derives Eq: | ||
|
|
||
| def modeTypeTag: String = "flamingos_2_long_slit" |
There was a problem hiding this comment.
These seem to be 1:1 with the lucuma.core.enums.ObservingModeType. Perhaps we could use that here?
swalker2m
reviewed
Oct 16, 2025
| obs_rec.c_observing_mode_type::text || '/' || 'telluric' || '/' || obs_rec.c_observation_id, | ||
| NULL, | ||
| NULL, | ||
| false, |
There was a problem hiding this comment.
The order will matter for tellurics won't it? Maybe the properties are edited when you add the calibrations though?
swalker2m
reviewed
Oct 16, 2025
| -- Only system groups can have calibration roles | ||
| ALTER TABLE t_group | ||
| ADD CONSTRAINT group_calibration_roles_system_only_check | ||
| CHECK (c_system = true OR c_calibration_roles = '{}'); |
There was a problem hiding this comment.
Is the idea that the UI will hide the groups with calibration roles associated with single observations? Do we care which calibrations go in there or just whether they are per-observation vs. per-unique config?
There was a problem hiding this comment.
I put this just for completness seemed odd to have the current calibrations group without roles
swalker2m
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that the calibration system is more complicated than originally designed. There are several families of calibrations. The one we have implemented now is called per program per configuration and includes twilights and spectrophotometric.
The next one is for tellurics and we will call it per science observation. In this PR we do a large refactoring splitting
CalibrationServiceservices into two while the original one remains as a coordinator.We also implement the first step where all flamingos 2 longslit observations will be in its own system group. The creation and dissolution of these groups is automatically handled by the system.
Now system groups can have a list of calibration roles as well.