Skip to content

Remove deprecated stylelint github formatter #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
Merged

Remove deprecated stylelint github formatter #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,13 +423,13 @@ jobs:
- name: Run linters
run: |
find ui/lib/src/main/resources/lucuma-css -maxdepth 1 -type f -exec sed -n -e '/^[[:space:]]*--.*;[[:space:]]*$/p' -e '/^[[:space:]]*--[^;]*$/,/;$/p' {} + >vars.css
npx stylelint --formatter github explore/common/src/main/webapp/sass
npx stylelint --formatter github observe/web/client/src/main/webapp/styles
npx stylelint --formatter github ui/lib/src/main/resources/lucuma-css
npx stylelint explore/common/src/main/webapp/sass
npx stylelint observe/web/client/src/main/webapp/styles
npx stylelint ui/lib/src/main/resources/lucuma-css
rm vars.css
find ui/lib/src/main/resources/lucuma-css -maxdepth 1 -type f -exec sed -n -e '/^[[:space:]]*--.*;[[:space:]]*$/p' -e '/^[[:space:]]*--[^;]*$/,/;$/p' {} + >vars.css
npx stylelint --formatter github explore/common/src/main/webapp/sass
npx stylelint --formatter github observe/web/client/src/main/webapp/styles
npx stylelint --formatter github ui/lib/src/main/resources/lucuma-css
npx stylelint explore/common/src/main/webapp/sass
npx stylelint observe/web/client/src/main/webapp/styles
npx stylelint ui/lib/src/main/resources/lucuma-css
rm vars.css
npx prettier --check .
4 changes: 2 additions & 2 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,10 +945,10 @@ def prettierCmd(fix: Boolean): String =
s"npx prettier ${if (fix) "--write" else "--check"} ."

def styleLintCmds(mode: String, fix: Boolean, dirs: List[String]): List[String] = {
val stylelintFixFlag = if (fix) " --fix" else ""
val stylelintFixFlag = if (fix) "--fix " else ""
// Removes all lines that don't define a variable, thus building a viable CSS file for linting. Thanks ChatGPT.
(raw"""find ui/lib/src/main/resources/lucuma-css -maxdepth 1 -type f -exec sed -n -e '/^[[:space:]]*--.*;[[:space:]]*$$/p' -e '/^[[:space:]]*--[^;]*$$/,/;$$/p' {} + >vars.css"""
+: dirs.map(dir => s"npx stylelint --formatter github $stylelintFixFlag $dir")) :+
+: dirs.map(dir => s"npx stylelint $stylelintFixFlag$dir")) :+
"rm vars.css"
}

Expand Down
Loading