Skip to content

Preparation for displaying blind offsets in explore #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

Preparation for displaying blind offsets in explore #76

merged 1 commit into from
Oct 15, 2025

Conversation

toddburnside
Copy link
Contributor

@toddburnside toddburnside commented Oct 15, 2025 •
edited
Loading

  • Add the disposition and calibration role to TargetWithId and thread that through explore. This makes it more like TargetWithMetadata, but renaming it would have made this PR even less readable.
  • Add the blind offset information to Observation
  • Unrelatedly, filters program targets by name for the target search dialog on the server rather than locally. Although, since we have all of the targets downloaded, it seems like we could avoid an API call.

cquiroz
cquiroz approved these changes Oct 15, 2025
View reviewed changes
Copy link
Contributor

@cquiroz cquiroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toddburnside toddburnside merged commit 0f42f23 into main Oct 15, 2025
17 checks passed
@toddburnside toddburnside deleted the sc-6671-prepare-to-display-blind-offsets branch October 15, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cquiroz cquiroz cquiroz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@toddburnside @cquiroz