Skip to content

Conversation

davner
Copy link
Member

@davner davner commented Oct 20, 2025

  • Update gpp-client dependency to version 25.10.3.

Checklist

  • Added a release note in doc/changes using the PR number.

@davner davner self-assigned this Oct 20, 2025
@davner davner requested a review from Copilot October 20, 2025 22:46
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds hidden input fields to observation forms to support form submission requirements while updating the gpp-client dependency to version 25.10.3.

  • Added three hidden input fields for observation ID, target ID, and observing mode
  • Implemented hidden input handling in the form creation logic with early return to avoid layout disruption
  • Updated gpp-client dependency from 25.10.1 to 25.10.3

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
src/goats_tom/static/js/gpp/observation_form.js Added logic to handle hidden input field creation with early return and added explanatory comments for section headers and special field handlers
src/goats_tom/static/js/gpp/fields.js Added three hidden field configurations for observation ID, target ID, and observing mode in the SHARED_FIELDS array
src/goats_tom/api_views/gpp/observations.py Added FIXME comment questioning data source for opportunity field
pyproject.toml Updated gpp-client dependency version from 25.10.1 to 25.10.3

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.36%. Comparing base (3807b94) to head (bf5ee5f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #464   +/-   ##
=======================================
  Coverage   78.36%   78.36%           
=======================================
  Files         256      256           
  Lines        8164     8164           
  Branches      487      487           
=======================================
  Hits         6398     6398           
  Misses       1677     1677           
  Partials       89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Update gpp-client dependency to version 25.10.3.
@davner davner force-pushed the GOATS-962/hidden-fields branch from c3debe2 to 7a553eb Compare October 20, 2025 22:51
@davner davner merged commit 0d5aee5 into main Oct 20, 2025
7 checks passed
@davner davner deleted the GOATS-962/hidden-fields branch October 21, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant