Skip to content

Feature/build testing #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Feature/build testing #483

merged 3 commits into from
Jan 29, 2025

Conversation

rg936672
Copy link
Contributor

@rg936672 rg936672 commented Jan 27, 2025

PR Type

  • Build related changes
  • CI related changes
  • Documentation content changes

Description

Closes #468. The workflow and updated CONTRIBUTING wording are copied with very minor edits from Coreax.

Note that this PR is dependent on/closes #481, as it contains commits from that PR - this was done intentionally to avoid merge conflicts in CONTRIBUTING.md

How Has This Been Tested?

The workflow actually hasn't been tested here, but has been copied (with very minor edits) from Coreax - see gchq/coreax#858.

Does this PR introduce a breaking change?

No

Screenshots

N/A

Checklist before requesting a review

  • I have made sure that my PR is not a duplicate.
  • My code follows the style guidelines of this project.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have performed a self-review of my code.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@rg936672 rg936672 force-pushed the feature/build-testing branch from 193e039 to b4c6e22 Compare January 28, 2025 09:26
@rg936672 rg936672 marked this pull request as ready for review January 29, 2025 16:25
@qh681248 qh681248 self-requested a review January 29, 2025 16:37
qh681248
qh681248 previously approved these changes Jan 29, 2025
@rg936672 rg936672 dismissed qh681248’s stale review January 29, 2025 16:47

The merge-base changed after approval.

qh681248
qh681248 previously approved these changes Jan 29, 2025
Copy link
Contributor

@qh681248 qh681248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes

@rg936672 rg936672 dismissed qh681248’s stale review January 29, 2025 16:52

The merge-base changed after approval.

@qh681248 qh681248 self-requested a review January 29, 2025 17:01
qh681248
qh681248 previously approved these changes Jan 29, 2025
@rg936672 rg936672 dismissed qh681248’s stale review January 29, 2025 17:03

The merge-base changed after approval.

@qh681248 qh681248 self-requested a review January 29, 2025 17:10
qh681248
qh681248 previously approved these changes Jan 29, 2025
Copy link
Contributor

@qh681248 qh681248 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with all the changes

@rg936672 rg936672 dismissed qh681248’s stale review January 29, 2025 17:11

The merge-base changed after approval.

qh681248
qh681248 previously approved these changes Jan 29, 2025
@qh681248 qh681248 merged commit 315d5bb into main Jan 29, 2025
17 checks passed
@qh681248 qh681248 deleted the feature/build-testing branch January 29, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve build testing process
2 participants