Skip to content

Conversation

rjl493456442
Copy link

  • Fix node size in SerializeNode
  • Track depth in node.Insert
  • Copy the key-encoding logic from verkle, making it self-contained

@rjl493456442 rjl493456442 requested a review from gballet as a code owner August 29, 2025 07:39
Copy link
Owner

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the encoding bug. For the record, I think that adding the depth to Insert is exposing an internal field externally, and that's not generally a good thing. But it doesn't change the correctness, so why not. Regarding the move of key functions from utils go` bintrie, this is ok for now, but it will break some unmerged code because it will create a cyclic dependency. But I'll move the file back when we get there, it makes sense to have it here for now.

@gballet gballet merged commit 123723b into gballet:add-binary-tree-tests Aug 29, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants