Skip to content

Optimize load time and memory consumption by reusing element descriptions #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 11, 2025
Merged

Optimize load time and memory consumption by reusing element descriptions #1589

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e169b4e
Do not clone element descriptions
azeey Sep 5, 2025
856d4d1
Add MutableElementDescription and deprecate GetElementDescription
azeey Sep 10, 2025
03f8f96
Add tests
azeey Sep 11, 2025
ac0646e
Remove stray include
azeey Sep 11, 2025
393bd61
Narrower use of GZ_UTILS_WARN_* macros
scpeters Sep 11, 2025
667049c
Suggestions for PR 1589
scpeters Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Element.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ ElementPtr Element::Clone(sdf::Errors &_errors) const
for (eiter = this->dataPtr->elementDescriptions.begin();
eiter != this->dataPtr->elementDescriptions.end(); ++eiter)
{
clone->dataPtr->elementDescriptions.push_back((*eiter)->Clone(_errors));
clone->dataPtr->elementDescriptions.push_back(*eiter);
}

for (eiter = this->dataPtr->elements.begin();
Expand Down Expand Up @@ -348,7 +348,7 @@ void Element::Copy(const ElementPtr _elem, sdf::Errors &_errors)
_elem->dataPtr->elementDescriptions.begin();
iter != _elem->dataPtr->elementDescriptions.end(); ++iter)
{
this->dataPtr->elementDescriptions.push_back((*iter)->Clone(_errors));
this->dataPtr->elementDescriptions.push_back(*iter);
}

this->dataPtr->elements.clear();
Expand Down Expand Up @@ -1200,7 +1200,7 @@ ElementPtr Element::AddElement(const std::string &_name, sdf::Errors &_errors)
for (unsigned int i = 0; i < parent->GetElementDescriptionCount(); ++i)
{
this->dataPtr->elementDescriptions.push_back(
parent->GetElementDescription(i)->Clone(_errors));
parent->GetElementDescription(i));
}
}

Expand Down
Loading