Build sdformattest pybind11 library as MODULE (backport #1544) #1576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=80&v=4){kind=small}
Signed-off-by: Silvio Traversaro <silvio@traversaro.it> Co-authored-by: Steve Peters <scpeters@openrobotics.org> (cherry picked from commit 71fe504)
8 tasks
|
@osrf-jenkins run tests please |
1 similar comment
|
@osrf-jenkins run tests please |
|
some tests failed that download a schema from http://sdformat.org since that server was down it's back up now @osrf-jenkins run tests please |
|
there are some python test failures on macOS |
azeey
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes segmentation fault of
pyParserConfig_TESTon macOS when building the library against conda-forge dependencies.Summary
I was investigating a segmentation fault in conda-forge/libsdformat-feedstock#134, and I isolated the problem to the
sdformattesttest Python module to be defined as aSHAREDlibrary. By changing it to aMODULE, the module loads fine (without segfaults) and the test passes fine.Why the problem only occurs on conda-forge and not with Homebrew's Python (that I guess is used by tests)? I am not completely sure about this, but I guess it boils down to conda-forge using a
pythonexecutable that statically linkslibpython, while Homebrew uses a Python that is dynamically linked tolibpython, see the related issues:Beside platform-specific problems, it seems that all other invocations of
pybind11_add_modulein gz projects useMODULE, so I think it make sense to switch toMODULEalso here at least for consistency.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.This is an automatic backport of pull request #1544 done by [Mergify](https://mergify.com).