Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 19, 2025

🎉 New feature

Part of gazebosim/gz-sim#2787

Summary

This PR adds AxisAlignedBox support for SDF geometries. Now each volumetric geometry type such as Box, Capsule, Cone, Cylinder, Ellipsoid, Sphere, and Mesh has a new AxisAlignedBox() function that computes its bounding box from the geometry dimensions. The Geometry class uses these functions to determine the correct AABB, allowing a custom calculator for meshes , which is a special case since no mesh loading is performed in the sdf::Mesh class.

Test it

  • Checkout the appropriate sdformat branch
  • Build this package
$ colcon build --packages-select sdformat15 --merge-install
  • Run the following sdformat15 tests:
$ ./build/sdformat15/bin/UNIT_Box_TEST && \
./build/sdformat15/bin/UNIT_Capsule_TEST && \
./build/sdformat15/bin/UNIT_Cone_TEST && \
./build/sdformat15/bin/UNIT_Cylinder_TEST && \
./build/sdformat15/bin/UNIT_Ellipsoid_TEST && \
./build/sdformat15/bin/UNIT_Sphere_TEST && \
./build/sdformat15/bin/UNIT_Mesh_TEST && \
./build/sdformat15/bin/UNIT_Geometry_TEST
  • Run all package tests to veify everything is still passing:
$ colcon test --packages-select sdformat15 --merge-install

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #1547 done by Mergify.

This adds AxisAlignedBox support for SDF geometries. Now
each volumetric geometry type such as Box, Capsule, Cone,
Cylinder, Ellipsoid, Sphere, and Mesh has an AxisAlignedBox()
function that computes its bounding box from the geometry
dimensions. The Geometry class uses these functions to
determine the correct AABB, allowing a custom calculator for
meshes , which is a special case since no mesh loading is
performed in the sdf::Mesh class.

Signed-off-by: Gabriel Pacheco <gabriel.fpacheco@gmail.com>
(cherry picked from commit e073ffa)
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jun 19, 2025
@iche033 iche033 merged commit 3f296bd into sdf14 Jun 19, 2025
13 checks passed
@iche033 iche033 deleted the mergify/bp/sdf14/pr-1547 branch June 19, 2025 02:45
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants