Skip to content

Fix bazel build errors with clang #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2025
Merged

Fix bazel build errors with clang #1566

merged 2 commits into from
May 16, 2025

Conversation

shameekganguly
Copy link
Contributor

🦟 Bug fix

Summary

Fixes bazel build issues detected with

$ bazel build --action_env=CC=/usr/bin/clang ...

and

$ USE_BAZEL_VERSION=8.2.1 bazel build --incompatible_autoload_externally= ...

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@shameekganguly
Fix warnings and layering check for clang bazel build
ec8b3f2 
Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
@shameekganguly
More fixes
f8e81b8 
Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels May 16, 2025
@shameekganguly shameekganguly requested review from scpeters and removed request for scpeters May 16, 2025 22:51
@iche033 iche033 changed the title Shameek/bzlmod Fix bazel build errors with clang May 16, 2025
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development May 16, 2025
@iche033 iche033 merged commit 69fca32 into sdf15 May 16, 2025
18 checks passed
@iche033 iche033 deleted the shameek/bzlmod branch May 16, 2025 23:51
@github-project-automation github-project-automation bot moved this from In review to Done in Core development May 16, 2025
@shameekganguly shameekganguly mentioned this pull request May 19, 2025
Merged
bazel-io pushed a commit to bazelbuild/bazel-central-registry that referenced this pull request May 19, 2025
@shameekganguly
Add sdformat v15.3.0.bcr.1 (#4618)
2929d55 
Pulls in BUILD.bazel fixes from
gazebosim/sdformat#1567 and
gazebosim/sdformat#1566.

Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
filmil pushed a commit to filmil/bazel-central-registry that referenced this pull request Jun 23, 2025
@shameekganguly @filmil
Add sdformat v15.3.0.bcr.1 (bazelbuild#4618)
9f8b193 
Pulls in BUILD.bazel fixes from
gazebosim/sdformat#1567 and
gazebosim/sdformat#1566.

Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iche033 iche033 iche033 approved these changes

@azeey azeey Awaiting requested review from azeey azeey is a code owner

@scpeters scpeters Awaiting requested review from scpeters scpeters is a code owner

Assignees

No one assigned

Labels

🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty

Projects

Core development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shameekganguly @iche033