Fix Crash On Negative Value

[shadygm]

🦟 Bug fix

Fixes gazebosim/gz-sim#2616

Summary

This PR introduces a fix for Gazebo crashing whenever an sdf element with negative size parameter was loaded. This is done by by simply adding a check in the load function of each element to identify whether the parameter that is being loaded is negative or not.

You can test it by running:
gz sim -v 3 c5.xml

c5.txt

From there, you should be seeing some warnings and all of the shapes.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[arjo129]

Thanks for being super thorough.

Some minor style issues were highlighted by the CI:

/usr/share/gz/gz-cmake4/codecheck/cpplint.py:55: DeprecationWarning: module 'sre_compile' is deprecated
    import sre_compile
  /github/workspace/src/Box_TEST.cc:156:  At least two spaces is best between code and comments  [whitespace/comments] [2]
  /github/workspace/src/Cone_TEST.cc:190:  At least two spaces is best between code and comments  [whitespace/comments] [2]
  /github/workspace/src/Cone_TEST.cc:198:  At least two spaces is best between code and comments  [whitespace/comments] [2]
  /github/workspace/src/Cylinder_TEST.cc:186:  At least two spaces is best between code and comments  [whitespace/comments] [2]
  /github/workspace/src/Cylinder_TEST.cc:194:  At least two spaces is best between code and comments  [whitespace/comments] [2]
  /github/workspace/src/Plane.cc:104:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]

Otherwise LGTM

[arjo129]

I think you forgot to sign-off on the last two commits. You may have to force push. Instructions are here: https://github.com/gazebosim/sdformat/pull/1553/checks?check_run_id=39982138989

[shadygm]

I think you forgot to sign-off on the last two commits.

Yes you're right, still not used to it 🥲