Code cleanup #1552
Merged
Code cleanup #1552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maksim Derbasov <ntfs.hard@gmail.com>
ntfshard
commented
Mar 13, 2025
| "@gz-math", | ||
| "@gz-utils//:Environment", | ||
| "@gz-utils//:ImplPtr", | ||
| "@gz-utils//:NeverDestroyed", |
There was a problem hiding this comment.
was included in 1 file but not used across whole repo. removed in both places
There was a problem hiding this comment.
👍
for reference, its last usage was removed in #1456
There was a problem hiding this comment.
Yeah, very questionable code from C++ perspective. It could be nice if we can remove it everythere to have a clean valgrind reports C:
Comment on lines
-137
to
+139
| const std::string _groupLabel, | ||
| const std::string _axisLabel, | ||
| sdf::Noise& _noise) | ||
| const std::string &_groupLabel, | ||
| const std::string &_axisLabel, | ||
| sdf::Noise &_noise) |
There was a problem hiding this comment.
it's lambda in scope, ok to add missing & here
ahcorde
approved these changes
Mar 13, 2025
ahcorde
previously requested changes
Mar 13, 2025
Signed-off-by: Maksim Derbasov <ntfs.hard@gmail.com>
scpeters
approved these changes
Mar 13, 2025
| "@gz-math", | ||
| "@gz-utils//:Environment", | ||
| "@gz-utils//:ImplPtr", | ||
| "@gz-utils//:NeverDestroyed", |
There was a problem hiding this comment.
👍
for reference, its last usage was removed in #1456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #
Summary
General code cleanup
Also I found several places where public API are getting
std::stringnot by reference, but by copy:I guess it could be hard to change it right now (w/o breaking ABI) and I have more doubts about returning by-copy strings across whole api... Just sharing, out of scope of this PR
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.