Skip to content

Improve error messages when embedSdf.py fails #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 4, 2025
Merged

Improve error messages when embedSdf.py fails #1549

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a44ccb2
Improve error message for missing EmbeddedSdf.cc
scpeters Mar 3, 2025
1ca9bb6
Check embedSdf.py return code and stderr
scpeters Mar 3, 2025
fc40ee2
fix whitespace
scpeters Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions sdf/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,25 @@ endif()

# Generate the EmbeddedSdf.cc file, which contains all the supported SDF
# descriptions in a map of strings. The parser.cc file uses EmbeddedSdf.hh.
set(EMBEDDED_SDF_CC_PATH "${PROJECT_BINARY_DIR}/src/EmbeddedSdf.cc")
execute_process(
COMMAND ${Python3_EXECUTABLE} ${CMAKE_SOURCE_DIR}/sdf/embedSdf.py
--output-file "${PROJECT_BINARY_DIR}/src/EmbeddedSdf.cc"
--output-file "${EMBEDDED_SDF_CC_PATH}"
WORKING_DIRECTORY "${CMAKE_SOURCE_DIR}/sdf"
RESULT_VARIABLE EMBEDDED_SDF_RESULT
ERROR_VARIABLE EMBEDDED_SDF_ERROR
)
file(SIZE "${PROJECT_BINARY_DIR}/src/EmbeddedSdf.cc" OUT_SIZE)
if(${OUT_SIZE} EQUAL 0)
message(FATAL_ERROR "Problems executing ${Python3_EXECUTABLE} ${CMAKE_SOURCE_DIR}/sdf/embedSdf.py")
# check process return code
if(NOT EMBEDDED_SDF_RESULT EQUAL 0)
message(FATAL_ERROR "Error executing ${Python3_EXECUTABLE} ${CMAKE_SOURCE_DIR}/sdf/embedSdf.py to create ${EMBEDDED_SDF_CC_PATH}: ${EMBEDDED_SDF_ERROR}")
endif()
# check that EmbeddedSdf.cc exists with non-zero size
# this should not happen if embedSdf.py was successful
if(EXISTS "${EMBEDDED_SDF_CC_PATH}")
file(SIZE "${EMBEDDED_SDF_CC_PATH}" EMBEDDED_SDF_CC_SIZE)
endif()
if("${EMBEDDED_SDF_CC_SIZE}" STREQUAL "0" OR "${EMBEDDED_SDF_CC_SIZE}" STREQUAL "")
message(FATAL_ERROR "${EMBEDDED_SDF_CC_PATH} is empty or does not exist")
endif()

# Generate aggregated SDF description files for use by the sdformat.org
Expand Down
Loading