Use std::vector::reserve in Element::Clone

[scpeters]

🦟 Bug fix

Part of #1478

Summary

The performance of Element::Clone is poor, as noted in #1478. This is a small change to attempt to improve memory allocation.

There are several for-loops in Element::Clone that call std::vector::push_back, and since the vector size is known in advance, use std::vector::reserve to avoid multiple vector resizes.

I ran the unit tests with this change, and I didn't observe any noticeable speed-up.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[azeey]

@scpeters not sure if we'll have time to tackle #1478. This PR looks fine as is, but it's a draft, so I wasn't if you wanted to do more. Let me know if you want to keep it in the "Jetty Release" milestone.

[scpeters]

@scpeters not sure if we'll have time to tackle #1478. This PR looks fine as is, but it's a draft, so I wasn't if you wanted to do more. Let me know if you want to keep it in the "Jetty Release" milestone.

we can remove this from the jetty release milestone