Skip to content

Set GZ_IP for gz_src_TEST #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2025
Merged

Set GZ_IP for gz_src_TEST #723

merged 1 commit into from
Sep 29, 2025

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Sep 29, 2025 •
edited
Loading

🦟 Bug fix

Similar to #595 but for UNIT_gz_src_TEST

Summary

I noticed that UNIT_gz_src_TEST has been failing with networking error messages, so this applies the GZ_IP=127.0.0.1 fix from #595 to that test as well.

Example failures:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

@scpeters
Set GZ_IP for gz_src_TEST
4186233 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters marked this pull request as ready for review September 29, 2025 19:04
@scpeters scpeters requested a review from caguero as a code owner September 29, 2025 19:04
@scpeters scpeters requested a review from Crola1702 September 29, 2025 19:05
azeey
azeey approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should do this for all of our tests that use gz-transport.

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Sep 29, 2025
@scpeters scpeters mentioned this pull request Sep 29, 2025
Open
4 tasks
@scpeters
Copy link
Member Author

I think we should do this for all of our tests that use gz-transport.

sounds good, tracking in #724

@scpeters scpeters merged commit 7dcb6eb into main Sep 29, 2025
14 checks passed
@scpeters scpeters deleted the scpeters/gz_ip_gz_src_test branch September 29, 2025 21:33
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Sep 29, 2025
@scpeters
Copy link
Member Author

https://github.com/Mergifyio backport gz-transport15 gz-transport14 gz-transport13 ign-transport11

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 30, 2025 •
edited
Loading

backport gz-transport15 gz-transport14 gz-transport13 ign-transport11

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 30, 2025
@scpeters @mergify
Set GZ_IP for gz_src_TEST (#723)
0f04a81 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
(cherry picked from commit 7dcb6eb)
@mergify mergify bot mentioned this pull request Sep 30, 2025
Merged
9 tasks
mergify bot pushed a commit that referenced this pull request Sep 30, 2025
@scpeters @mergify
Set GZ_IP for gz_src_TEST (#723)
a17e00e 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
(cherry picked from commit 7dcb6eb)
mergify bot pushed a commit that referenced this pull request Sep 30, 2025
@scpeters @mergify
Set GZ_IP for gz_src_TEST (#723)
dfcc26d 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
(cherry picked from commit 7dcb6eb)
This was referenced Sep 30, 2025
Merged
Merged
mergify bot pushed a commit that referenced this pull request Sep 30, 2025
@scpeters @mergify
Set GZ_IP for gz_src_TEST (#723)
bc816f0 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
(cherry picked from commit 7dcb6eb)
@mergify mergify bot mentioned this pull request Sep 30, 2025
Merged
9 tasks
scpeters added a commit that referenced this pull request Sep 30, 2025
@scpeters
Set GZ_IP for gz_src_TEST (#723)
893f31b 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
(cherry picked from commit 7dcb6eb)
scpeters added a commit that referenced this pull request Sep 30, 2025
@scpeters
Set GZ_IP for gz_src_TEST (#723)
8abe13b 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
(cherry picked from commit 7dcb6eb)
scpeters added a commit that referenced this pull request Sep 30, 2025
@scpeters
Set GZ_IP for gz_src_TEST (#723)
9c3e903 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
(cherry picked from commit 7dcb6eb)
scpeters added a commit that referenced this pull request Sep 30, 2025
@scpeters
Set GZ_IP for gz_src_TEST (#723)
b1cd747 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
(cherry picked from commit 7dcb6eb)
iche033 pushed a commit that referenced this pull request Oct 1, 2025
@scpeters @iche033
Set GZ_IP for gz_src_TEST (#723)
d4bdf93 
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azeey azeey azeey approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

@Crola1702 Crola1702 Awaiting requested review from Crola1702

Assignees

No one assigned

Labels

None yet

Projects

Core development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scpeters @azeey