Skip to content

Initialize move constructor #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2025
Merged

Initialize move constructor #718

merged 1 commit into from
Sep 29, 2025

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Sep 27, 2025

🦟 Bug fix

Fixes #717

Summary

Properly initializes the move constructor.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

@caguero
Initialize move constructor
0fa3330 
Signed-off-by: Carlos Agüero <caguero@osrfoundation.org>
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Sep 29, 2025
@caguero caguero merged commit ede1091 into main Sep 29, 2025
14 checks passed
@caguero caguero deleted the fix_issue_717 branch September 29, 2025 07:57
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Sep 29, 2025
@caguero
Copy link
Collaborator Author

caguero commented Sep 29, 2025

@Mergifyio backport gz-transport15 gz-transport14 gz-transport13 ign-transport11

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 29, 2025 •
edited
Loading

backport gz-transport15 gz-transport14 gz-transport13 ign-transport11

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 29, 2025
@caguero @mergify
Initialize move constructor (#718)
3917fbd 
Signed-off-by: Carlos Agüero <caguero@osrfoundation.org>
(cherry picked from commit ede1091)
@mergify mergify bot mentioned this pull request Sep 29, 2025
Merged
9 tasks
mergify bot pushed a commit that referenced this pull request Sep 29, 2025
@caguero @mergify
Initialize move constructor (#718)
66ae6b8 
Signed-off-by: Carlos Agüero <caguero@osrfoundation.org>
(cherry picked from commit ede1091)
mergify bot pushed a commit that referenced this pull request Sep 29, 2025
@caguero @mergify
Initialize move constructor (#718)
3273f55 
Signed-off-by: Carlos Agüero <caguero@osrfoundation.org>
(cherry picked from commit ede1091)
This was referenced Sep 29, 2025
Merged
Merged
mergify bot pushed a commit that referenced this pull request Sep 29, 2025
@caguero @mergify
Initialize move constructor (#718)
f98f908 
Signed-off-by: Carlos Agüero <caguero@osrfoundation.org>
(cherry picked from commit ede1091)

# Conflicts:
#	src/Node.cc
#	src/Node_TEST.cc
@mergify mergify bot mentioned this pull request Sep 29, 2025
Closed
9 tasks
caguero added a commit that referenced this pull request Oct 3, 2025
@mergify @caguero
Initialize move constructor (#718) (#720)
93ddde2 
(cherry picked from commit ede1091)

Signed-off-by: Carlos Agüero <caguero@osrfoundation.org>
Co-authored-by: Carlos Agüero <caguero@osrfoundation.org>
caguero added a commit that referenced this pull request Oct 3, 2025
@mergify @caguero
Initialize move constructor (#718) (#719)
81ce706 
(cherry picked from commit ede1091)

Signed-off-by: Carlos Agüero <caguero@osrfoundation.org>
Co-authored-by: Carlos Agüero <caguero@osrfoundation.org>
caguero added a commit that referenced this pull request Oct 3, 2025
@mergify @caguero
Initialize move constructor (#718) (#721)
78f9aac 
(cherry picked from commit ede1091)

Signed-off-by: Carlos Agüero <caguero@osrfoundation.org>
Co-authored-by: Carlos Agüero <caguero@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Core development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@caguero @ahcorde