Skip to content

Add null-check for gz param parameters in three functions to prevent crashes (backport #709) #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2025
Merged

Add null-check for gz param parameters in three functions to prevent crashes (backport #709) #713

merged 1 commit into from
Sep 8, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 8, 2025

🦟 Bug fix

Fixes gz-sim Issue#3079

Summary

When using the gz param command, it crashes because subsequent parameters do not have validity checks.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
This is an automatic backport of pull request #709 done by [Mergify](https://mergify.com).

@XINJIANGMO @mergify
Add null-check for gz param parameters in three functions to preven…
a0b4ca8 
…t crashes (#709)

Signed-off-by: momo <2438833481@qq.com>
(cherry picked from commit b462b3f)
@mergify mergify bot requested a review from caguero as a code owner September 8, 2025 12:28
@mergify mergify bot mentioned this pull request Sep 8, 2025
Merged
8 tasks
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 8, 2025
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Sep 8, 2025
@caguero caguero merged commit ef02e67 into ign-transport11 Sep 8, 2025
11 checks passed
@caguero caguero deleted the mergify/bp/ign-transport11/pr-709 branch September 8, 2025 13:43
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caguero caguero caguero approved these changes

Assignees

No one assigned

Labels

🏯 fortress Ignition Fortress

Projects

Core development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@caguero @XINJIANGMO