Skip to content

Add null-check for gz param parameters in three functions to prevent crashes (backport #709) #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2025
Merged

Add null-check for gz param parameters in three functions to prevent crashes (backport #709) #711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions parameters/src/cmd/ParamCommandAPI.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ using namespace transport;
//////////////////////////////////////////////////
extern "C" void cmdParametersList(const char * _ns)
{
if (!_ns)
{
std::cerr << "Error: Namespace is null" << std::endl;
return;
}
parameters::ParametersClient client{_ns};

std::cout << std::endl << "Listing parameters, registry namespace [" << _ns
Expand All @@ -63,6 +68,11 @@ extern "C" void cmdParametersList(const char * _ns)

//////////////////////////////////////////////////
extern "C" void cmdParameterGet(const char * _ns, const char *_paramName) {
if (!_ns || !_paramName)
{
std::cerr << "Error: Namespace or parameter name is null" << std::endl;
return;
}
parameters::ParametersClient client{_ns};

std::cout << std::endl << "Getting parameter [" << _paramName
Expand Down Expand Up @@ -96,6 +106,16 @@ extern "C" void cmdParameterSet(
const char * _ns, const char *_paramName, const char * _paramType,
const char *_paramValue)
{
if (!_ns || !_paramName)
{
std::cerr << "Error: Namespace or parameter name is null" << std::endl;
return;
}
if (!_paramType || !_paramValue)
{
std::cerr << "Error: Parameter type or value is null" << std::endl;
return;
}
parameters::ParametersClient client{_ns};

std::cout << std::endl << "Setting parameter [" << _paramName
Expand Down
Loading