Check message creation in zenoh before running local callback #708
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes this issue.
This patch avoids a crash when the
CreateMessage()
function wasn't able to create a message. When using zenoh, we weren't checking whether the message was successfully created or not.Note that
CreateMessage()
doesn't have to always create a message, there are situations where it's not possible to do. The most common case is when the publisher publishes a custom message and the subscriber doesn't have access to that message definition. This is what happens in the reported issue,gz topic echo
shouldn't work (unless it has access to the.desc
message files) but in any case it should not crash.How to test it?
Compile the examples:
In terminal 1:
In terminal 2:
No output should appear on the terminal but nothing should crash.
Summary
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
andGenerated-by
messages.