Skip to content

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Sep 3, 2025

🦟 Bug fix

Fixes the topic info in the generic subscription callback. When asking for Topic(), the returned string was containing the partition name and it shouldn't. This only happens using zenoh.

E.g.:

./publisher

and

./subscriber_generic 
Topic: [@/flaco:caguero@/foo]
data: "HELLO"

However, topic should be just /foo. This patch fixes the issue.

Note: The ABI checker job is expected to fail.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Signed-off-by: Carlos Agüero <caguero@osrfoundation.org>
Signed-off-by: Carlos Agüero <caguero@osrfoundation.org>
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Sep 3, 2025
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Sep 3, 2025
@caguero caguero merged commit 3b46aec into gz-transport15 Sep 3, 2025
14 of 15 checks passed
@caguero caguero deleted the caguero_zenoh_fix_topic_info branch September 3, 2025 15:26
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants