[Bazel] Bump libzmq dep to 4.3.5.bcr.3 #636
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
This fixes clang build under
--copt=-Werror --per_file_copt=+external/.*@-Wno-everything
. Verified withThe
--per_file_copt
setting excludes warnings from external dependencies from causing build failure. However,libzmq
in particular usesrules_foreign_cc:cmake
to build, which does not respect the--per_file_copt
setting. There was one error from-Wmissing-braces
inlibzmq
that was fixed in BCR .This PR updates the
libzmq
dep version to fix the build.Also requires in a version bump for bazel-contrib/.github/.github/workflows/bazel.yaml which we use for bazel CI since there is an error with
rules_java
brought in transitively with the libzmq update. Now, Bazel 8.x CI uses bazel 8.0.0 instead of 8.0.0rc1.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.