Skip to content

Conversation

shameekganguly
Copy link
Contributor

@shameekganguly shameekganguly commented May 21, 2025

🦟 Bug fix

Summary

This fixes clang build under --copt=-Werror --per_file_copt=+external/.*@-Wno-everything. Verified with

$ bazel build --copt=-Werror --per_file_copt=+external/.*@-Wno-everything --action_env=CC=/usr/bin/clang :all

The --per_file_copt setting excludes warnings from external dependencies from causing build failure. However, libzmq in particular uses rules_foreign_cc:cmake to build, which does not respect the --per_file_copt setting. There was one error from -Wmissing-braces in libzmq that was fixed in BCR .

This PR updates the libzmq dep version to fix the build.

Also requires in a version bump for bazel-contrib/.github/.github/workflows/bazel.yaml which we use for bazel CI since there is an error with rules_java brought in transitively with the libzmq update. Now, Bazel 8.x CI uses bazel 8.0.0 instead of 8.0.0rc1.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development May 21, 2025
Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
@iche033 iche033 merged commit 867655e into gz-transport14 May 21, 2025
14 checks passed
@iche033 iche033 deleted the shameek/bazel branch May 21, 2025 20:51
@github-project-automation github-project-automation bot moved this from In review to Done in Core development May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants