Skip to content

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented May 15, 2025

🦟 Bug fix

Fixes #

Summary

Install additional ros-jazzy-ros-environment package so users can take a more ROS-friendly way of setting up ROS env by sourcing the setup.bash script, see gazebo-tooling/release-tools#1311 (comment)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested a review from caguero as a code owner May 15, 2025 18:42
@iche033 iche033 marked this pull request as draft May 15, 2025 18:42
@iche033 iche033 changed the title source setup bash Install addition ROS package for setting up ROS env May 15, 2025
@iche033 iche033 changed the title Install addition ROS package for setting up ROS env Install additional ROS package for setting up ROS env May 15, 2025
@iche033
Copy link
Contributor Author

iche033 commented May 15, 2025

Ubuntu CI / Ubuntu Noble CI - Zenoh (pull_request) successfully detects the ROS 2 zenoh packages:

-- defined lib target zenohcxx::zenohc for zenohc::lib
  -- Looking for zenohcxx - found
  
  -- Looking for zenohcxx and zenohc - found

Jenkins build also works, see gazebo-tooling/release-tools#1311 (comment)

@iche033 iche033 marked this pull request as ready for review May 15, 2025 19:10
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development May 15, 2025
@iche033 iche033 merged commit 3b9d693 into zenoh_main_pub_sub May 15, 2025
7 checks passed
@iche033 iche033 deleted the iche033/zenoh_main_pub_sub_ros_env branch May 15, 2025 20:12
@github-project-automation github-project-automation bot moved this from In review to Done in Core development May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants