Skip to content

Conversation

scpeters
Copy link
Member

Bumping gz-cmake and others except gz-tools.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member Author

I'm guessing these test failures are related to a problem with gz-msgs

@scpeters
Copy link
Member Author

I'm guessing these test failures are related to a problem with gz-msgs

I added some extra console output to the failing tests, and it looks to me like a consequence of a behavior change in gazebosim/gz-msgs#476 that has never before been tested with gz-transport

from migration guide:

    The function `MessageFactory::MessagePtr MessageFactory::New(
    const std::string &_msgType)` does not accept non-fully qualified names
    anymore.

@scpeters
Copy link
Member Author

I think because we are stripping the protobuf namespace here:

  • const char prefix[] = "gz.msgs.";
    auto ret = typeUrl.substr(pos + 1);
    if (!ret.compare(0, sizeof(prefix), prefix)) {
    return std::nullopt;
    }
    return ret.substr(sizeof(prefix) - 1);

@scpeters
Copy link
Member Author

I'm guessing these test failures are related to a problem with gz-msgs

I added some extra console output to the failing tests, and it looks to me like a consequence of a behavior change in gazebosim/gz-msgs#476 that has never before been tested with gz-transport

from migration guide:

    The function `MessageFactory::MessagePtr MessageFactory::New(
    const std::string &_msgType)` does not accept non-fully qualified names
    anymore.

restoring this in gazebosim/gz-msgs#512 to facilitate these bumps

@scpeters
Copy link
Member Author

@iche033 the ubuntu jenkins build is failing since gazebo-tooling/release-tools#1311

# BEGIN SECTION: sourcing ros setup script
+ '[' -f /opt/ros/jazzy/setup.bash ']'
+ echo 'ROS_DISTRO_SETUP_NEEDED set to jazzy but no ROS 2 installation found'
ROS_DISTRO_SETUP_NEEDED set to jazzy but no ROS 2 installation found
+ exit 1

@iche033
Copy link
Contributor

iche033 commented May 16, 2025

hmm that should be fixed once the zenoh_main changes are merged into the main branch but think we're not ready to do that yet. I'll update release-tools to not exit 1 so we can continue building main without zenoh

@iche033
Copy link
Contributor

iche033 commented May 16, 2025

hmm that should be fixed once the zenoh_main changes are merged into the main branch but think we're not ready to do that yet. I'll update release-tools to not exit 1 so we can continue building main without zenoh

gazebo-tooling/release-tools#1317

@scpeters
Copy link
Member Author

bazel builds need the following to be merged forward

@scpeters
Copy link
Member Author

scpeters commented May 16, 2025

CI is happy now for this PR, so I opened all the other pull requests and started an Ubuntu colcon CI job with a custom repos file (gazebo-tooling/gazebodistro@a9a877d gazebo-tooling/gazebodistro@c5fc7c8 gazebo-tooling/gazebodistro@9da8b82):

if that looks ok, I'll open the pull requests for review, but I won't start merging until all the gazebosim/gz-* pull requests have been reviewed

@scpeters scpeters marked this pull request as ready for review May 19, 2025 08:48
@scpeters scpeters requested a review from caguero as a code owner May 19, 2025 08:48
@scpeters scpeters merged commit 85c045a into main May 19, 2025
15 of 18 checks passed
@scpeters scpeters deleted the ci_matching_branch/bump_jetty_gz-transport15 branch May 19, 2025 18:19
@github-project-automation github-project-automation bot moved this from In review to Done in Core development May 19, 2025
@scpeters
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants