-
Notifications
You must be signed in to change notification settings - Fork 53
Merge 14 -> main #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Merge 14 -> main #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* Cast nanoseconds to int64_t When `GetTime()->count()` doesn't return `int64_t`, unambiguously select `SqlParameter(int64_t _integer)`. Signed-off-by: Kai Pastor <dg0yt@darc.de> (cherry picked from commit 19a0de0) Co-authored-by: Kai Pastor <dg0yt@darc.de>
Includes a small fix for a doxygen complaint. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Adds a new API in Node class, namely CreateSubscriber. This function returns a Node::Subscriber object that allows the user to manage the lifetime of the subscription handler. When the Node::Subscriber is deleted (e.g. goes out of scope), it automatically removes the subscription handler from node. Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Add move constructor / assignment operator to fix unintended topic unsubscription Signed-off-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 138cf94)
--------- Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
* Migrate bazel build setup to use bzlmod Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai> * Cleanup Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai> * Remove define Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai> * Fix lint Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai> * Add bazel CI Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai> * Fix bazel CI failures Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai> --------- Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
Fixes bazel build failures for clang found with: `bazel build ... --action_env=CC=/usr/bin/clang` --------- Signed-off-by: Shameek Ganguly <shameek@intrinsic.ai>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
ahcorde
approved these changes
May 15, 2025
caguero
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port gz-transport14 to main
Branch comparison: main...gz-transport14
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)