Skip to content

Fix bazel build errors with clang #631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 12, 2025
Merged

Fix bazel build errors with clang #631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f67232f
Migrate bazel build setup to use bzlmod
shameekganguly May 8, 2025
dcb2f04
Cleanup
shameekganguly May 9, 2025
db23c12
Remove define
shameekganguly May 9, 2025
5853e00
Fix lint
shameekganguly May 9, 2025
2726c48
Merge branch 'gz-transport14' into shameek/bzlmod
shameekganguly May 9, 2025
ef7d08e
Add bazel CI
shameekganguly May 9, 2025
f1ed867
Fix bazel CI failures
shameekganguly May 10, 2025
08a2462
Fix clang bazel build
shameekganguly May 12, 2025
c51dba6
Merge branch 'gz-transport14' into shameek/bzlmod
shameekganguly May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,20 @@ cc_library(
copts = [
"-Wno-deprecated-declarations",
],
features = [
# Layering check fails for clang build due to no module exporting
# `google/protobuf/stubs/common.h`. Unfortunately, the bazel target that
# exports this header in protobuf is private.
"-layering_check",
],
includes = ["include"],
visibility = ["//visibility:public"],
deps = [
"@com_google_protobuf//:protobuf",
"@cppzmq",
"@gz-msgs",
"@gz-msgs//:gzmsgs_cc_proto",
"@gz-utils//:SuppressWarning",
"@libuuid",
"@libzmq",
],
Expand All @@ -85,7 +94,10 @@ cc_binary(
],
deps = [
":gz-transport",
"@gz-utils//cli",
"@com_google_protobuf//:json_util",
"@gz-msgs",
"@gz-utils//cli:GzFormatter",
"@gz-utils//cli:cli11",
],
)

Expand All @@ -101,7 +113,10 @@ cc_binary(
],
deps = [
":gz-transport",
"@gz-utils//cli",
"@com_google_protobuf//:json_util",
"@gz-msgs",
"@gz-utils//cli:GzFormatter",
"@gz-utils//cli:cli11",
],
)

Expand Down
13 changes: 13 additions & 0 deletions parameters/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,18 @@ cc_library(
name = "parameters",
srcs = sources + private_headers,
hdrs = public_headers,
features = [
# Layering check fails for clang build due to no module exporting
# `google/protobuf/any.h`. Unfortunately, the bazel target that exports
# this header in protobuf is private.
"-layering_check",
],
includes = ["include"],
visibility = ["//visibility:public"],
deps = [
"//:gz-transport",
"@com_google_protobuf//:protobuf",
"@gz-msgs//:gzmsgs_cc_proto",
"@sqlite3",
],
)
Expand All @@ -49,9 +57,14 @@ test_sources = glob(
[cc_test(
name = src.replace("/", "_").replace(".cc", "").replace("src_", ""),
srcs = [src],
copts = [
"-Wno-private-header", # Required for Utils_TEST
],
deps = [
":parameters",
"//test:utils",
"@googletest//:gtest",
"@googletest//:gtest_main",
"@gz-msgs//:gzmsgs_cc_proto",
],
) for src in test_sources]
Loading