Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 7, 2025

🎉 New feature

Summary

Backport the new Node::CreateSubscriber API function added in #608.

This PR does not backport the refactoring of the Node::Subscribe functions as that introduces a break change as mentioned in gazebosim/gz-sim#2894

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #622 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label May 7, 2025
@mergify mergify bot requested a review from caguero as a code owner May 7, 2025 18:53
Copy link
Contributor Author

mergify bot commented May 7, 2025

Cherry-pick of dea4643 has failed:

On branch mergify/bp/gz-transport13/pr-622
Your branch is up to date with 'origin/gz-transport13'.

You are currently cherry-picking commit dea4643.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   Migration.md
	modified:   include/gz/transport/Node.hh
	modified:   include/gz/transport/detail/Node.hh
	modified:   src/Node.cc
	modified:   src/NodePrivate.hh
	modified:   src/NodeSharedPrivate.hh
	modified:   src/Node_TEST.cc
	modified:   test/CMakeLists.txt
	modified:   test/integration/CMakeLists.txt
	new file:   test/integration/test_executables/twoProcsPubSubMixedSubscribers_aux.cc
	modified:   test/integration/twoProcsPubSub.cc
	modified:   test/test_config.hh.in

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   include/gz/transport/NodeShared.hh
	both modified:   src/NodeShared.cc

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label May 7, 2025
@mergify mergify bot mentioned this pull request May 7, 2025
9 tasks
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label May 7, 2025
iche033 added 2 commits May 7, 2025 21:02
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 force-pushed the mergify/bp/gz-transport13/pr-622 branch from 5708d05 to a1a210a Compare May 7, 2025 21:03
@iche033 iche033 removed the conflicts label May 7, 2025
Copy link

codecov bot commented May 7, 2025

Codecov Report

Attention: Patch coverage is 86.82635% with 22 lines in your changes missing coverage. Please review.

Project coverage is 86.73%. Comparing base (eac2e69) to head (a1a210a).
Report is 40 commits behind head on gz-transport13.

Files with missing lines Patch % Lines
src/NodeShared.cc 78.72% 20 Missing ⚠️
include/gz/transport/detail/Node.hh 94.11% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           gz-transport13     #623      +/-   ##
==================================================
- Coverage           87.69%   86.73%   -0.96%     
==================================================
  Files                  59       59              
  Lines                5704     5902     +198     
==================================================
+ Hits                 5002     5119     +117     
- Misses                702      783      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development May 8, 2025
@iche033 iche033 merged commit 2f90b63 into gz-transport13 May 8, 2025
8 of 11 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Core development May 8, 2025
@iche033 iche033 deleted the mergify/bp/gz-transport13/pr-622 branch May 8, 2025 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎵 harmonic Gazebo Harmonic

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant