Skip to content

Add Ubuntu Noble - Zenoh github action #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 12, 2025

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented May 2, 2025

🎉 New feature

Summary

Add a new Ubuntu github action for running gz-transport tests with zenoh. You should see a new check in this PR: [Ubuntu CI / Ubuntu Noble CI - Zenoh (pull_request)

This introduces a GZ_TRANSPORT_DEFAULT_IMPLEMENTATION cmake arg that can be configured at compile time to set the default transport implementation to use. By default it's zeromq. This cmake arg is set by the new github action in .github/workflow/ci.yml to zenoh. The GZ_TRANSPORT_IMPLEMENTATION env var should continue to work the same way, and when set, it'll override GZ_TRANSPORT_DEFAULT_IMPLEMENTATION.

Note: in the long run, we should consider implementing a common test frame work similar to the one in gz-rendering/test/common and gz-physics/test/common so we can run all tests with different transport implementations one after another in the same job.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

iche033 added 10 commits May 1, 2025 17:49
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it expected to fail?

@iche033
Copy link
Contributor Author

iche033 commented May 2, 2025

Is it expected to fail?

There are test failures in the build, which I also want to check with you. The services are not supported yet in this branch (branched off of #601) so I assume that's why the tests are failing. I also tried running UNIT_Node_TEST locally with zenoh but it crashes like in the CI job. So I think it's expected that not all tests should pass right?

@caguero
Copy link
Collaborator

caguero commented May 2, 2025

Is it expected to fail?

There are test failures in the build, which I also want to check with you. The services are not supported yet in this branch (branched off of #601) so I assume that's why the tests are failing. I also tried running UNIT_Node_TEST locally with zenoh but it crashes like in the CI job. So I think it's expected that not all tests should pass right?

Yes, not all tests should pass. For some reason I wasn't able to see any test result. That's why I was confused.

Could we limit this job to just a test (for now) that we know it passes?

@iche033 iche033 force-pushed the iche033/zenoh_main_pub_sub branch from 735026e to 0d88aaf Compare May 8, 2025 00:11
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 force-pushed the iche033/zenoh_main_pub_sub branch from 0d88aaf to 77837f0 Compare May 8, 2025 01:02
@iche033
Copy link
Contributor Author

iche033 commented May 8, 2025

Is it expected to fail?

There are test failures in the build, which I also want to check with you. The services are not supported yet in this branch (branched off of #601) so I assume that's why the tests are failing. I also tried running UNIT_Node_TEST locally with zenoh but it crashes like in the CI job. So I think it's expected that not all tests should pass right?

Yes, not all tests should pass. For some reason I wasn't able to see any test result. That's why I was confused.

Could we limit this job to just a test (for now) that we know it passes?

yes disabled all tests that are failing / crashing / timing out in zenoh. 77837f0. Note:

  • I added a getTransportImplementation() free function so that we can access it in python tests to determine whether or not to disable them.
  • Added CHECK_UNSUPPORTED_IMPLEMENTATION to help skip tests if certain transport implementation is not supported. Macro is similar to the one in used by the common test framework in gz-rendering

CI should be green now

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development May 11, 2025
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 merged commit 788ab2d into zenoh_main_pub_sub May 12, 2025
6 checks passed
@iche033 iche033 deleted the iche033/zenoh_main_pub_sub branch May 12, 2025 17:48
@github-project-automation github-project-automation bot moved this from In review to Done in Core development May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants