-
Notifications
You must be signed in to change notification settings - Fork 50
Add Ubuntu Noble - Zenoh github action #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it expected to fail?
There are test failures in the build, which I also want to check with you. The services are not supported yet in this branch (branched off of #601) so I assume that's why the tests are failing. I also tried running |
Yes, not all tests should pass. For some reason I wasn't able to see any test result. That's why I was confused. Could we limit this job to just a test (for now) that we know it passes? |
735026e
to
0d88aaf
Compare
Signed-off-by: Ian Chen <ichen@openrobotics.org>
0d88aaf
to
77837f0
Compare
yes disabled all tests that are failing / crashing / timing out in zenoh. 77837f0. Note:
CI should be green now |
🎉 New feature
Summary
Add a new Ubuntu github action for running gz-transport tests with zenoh. You should see a new check in this PR:
[Ubuntu CI / Ubuntu Noble CI - Zenoh (pull_request)
This introduces a
GZ_TRANSPORT_DEFAULT_IMPLEMENTATION
cmake arg that can be configured at compile time to set the default transport implementation to use. By default it'szeromq
. This cmake arg is set by the new github action in.github/workflow/ci.yml
tozenoh
. TheGZ_TRANSPORT_IMPLEMENTATION
env var should continue to work the same way, and when set, it'll overrideGZ_TRANSPORT_DEFAULT_IMPLEMENTATION
.Note: in the long run, we should consider implementing a common test frame work similar to the one in gz-rendering/test/common and gz-physics/test/common so we can run all tests with different transport implementations one after another in the same job.
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.