Skip to content

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Feb 3, 2025

Summary

Removed an unused forward declaration.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
@caguero caguero merged commit 75b3f72 into main Feb 3, 2025
11 checks passed
@caguero caguero deleted the messagePublisherPrivate branch February 3, 2025 17:07
@caguero
Copy link
Collaborator Author

caguero commented Feb 3, 2025

@Mergifyio backport gz-transport14

Copy link
Contributor

mergify bot commented Feb 3, 2025

backport gz-transport14

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 3, 2025
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
(cherry picked from commit 75b3f72)
caguero added a commit that referenced this pull request Feb 3, 2025
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
(cherry picked from commit 75b3f72)

Co-authored-by: Carlos Agüero <caguero@osrfoundation.org>
@caguero
Copy link
Collaborator Author

caguero commented Feb 3, 2025

@Mergifyio backport gz-transport13 ign-transport11

Copy link
Contributor

mergify bot commented Feb 3, 2025

backport gz-transport13 ign-transport11

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Feb 3, 2025
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
(cherry picked from commit 75b3f72)
mergify bot pushed a commit that referenced this pull request Feb 3, 2025
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
(cherry picked from commit 75b3f72)

# Conflicts:
#	include/gz/transport/Publisher.hh
caguero pushed a commit that referenced this pull request Mar 12, 2025
) (#573)

* Remove unused MessagePublisherPrivate forward declaration. (#570)
---------
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
caguero pushed a commit that referenced this pull request Mar 12, 2025
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
(cherry picked from commit 75b3f72)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants