Simplify the relay tutorial docker setup #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Removed build.sh and run.sh scripts that were really not needed to just run the relay example. Modify the instructions accordingly. Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
j-rivero
changed the title
caguero
reviewed
Sep 2, 2024
docker/Dockerfile
Outdated
| @@ -0,0 +1,68 @@ | |||
| # Ubuntu 22.04 | |||
docker/Dockerfile
Outdated
|
|
||
| # Install gazebo dependencies | ||
| RUN /bin/sh -c 'echo "deb [trusted=yes] http://packages.osrfoundation.org/gazebo/ubuntu-stable `lsb_release -cs` main" > /etc/apt/sources.list.d/gazebo-stable.list' \ | ||
| && /bin/sh -c 'echo "deb [trusted=yes] http://packages.osrfoundation.org/gazebo/ubuntu-prerelease `lsb_release -cs` main" > /etc/apt/sources.list.d/gazebo-prerelease.list' \ |
There was a problem hiding this comment.
I used this for testing but I think we should remove it.
caguero
requested changes
Sep 2, 2024
caguero
reviewed
Sep 3, 2024
| ./run.bash gz-transport | ||
| ``` | ||
|
|
||
| Inside the docker instance, go to the `example` directory: |
There was a problem hiding this comment.
The order here should be:
Run your Docker container:
docker run -it --rm gz-transport-relay /bin/bash
Inside the docker instance, go to the example directory:
cd /tmp/gz-transport/example/build
There was a problem hiding this comment.
The final WORKDIR at the end of the Dockerfile should leave you exactly in that directory ready to run the example binary https://github.com/gazebosim/gz-transport/pull/530/files#diff-f34da55ca08f1a30591d8b0b3e885bcc678537b2a9a4aadea4f190806b374ddcR64
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
caguero
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Simplify the docker setup for the relay example by removing the build.sh and run.sh scripts that were adding helpers for development but were really not needed to run the important code.
Summary
The two commits are self-explanatory:
Test it
I've verified that it builds just fine. @caguero verified that it runs fine.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.gazebo-release) (as needed):