Skip to content

Clean up namespaces #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Clean up namespaces #502

wants to merge 3 commits into from

Conversation

mjcarroll
Copy link
Contributor

Similar to what I've done in other places.

  • Use concatenated namespaces where possible.
  • Eliminate some uses of using namespace in cc files.
  • Add closing comments on namespaces and #ifdefs

mjcarroll added 3 commits May 15, 2024 20:28
@mjcarroll
Clean namespaces for log component
484ec79 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Clean namespaces for parameters component
a188f8c 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll
Clean up namespaces in core
626d7fa 
Signed-off-by: Michael Carroll <mjcarroll@intrinsic.ai>
@mjcarroll mjcarroll requested a review from caguero as a code owner May 16, 2024 13:09
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label May 16, 2024
caguero
caguero previously approved these changes May 16, 2024
View reviewed changes
@azeey azeey added the beta Targeting beta release of upcoming collection label Jul 29, 2024
@caguero caguero dismissed their stale review September 6, 2024 20:16

Let's do another review after the retarget

@azeey azeey removed the beta Targeting beta release of upcoming collection label Sep 26, 2024
@caguero caguero mentioned this pull request May 27, 2025
Merged
8 tasks
This was referenced May 28, 2025
Merged
Merged
Merged
@caguero caguero mentioned this pull request May 28, 2025
Merged
8 tasks
This was referenced May 29, 2025
Merged
Merged
Merged
@caguero caguero mentioned this pull request Jun 4, 2025
Merged
8 tasks
This was referenced Jun 4, 2025
Merged
Merged
Merged
@caguero caguero mentioned this pull request Jun 6, 2025
Merged
8 tasks
@caguero
Copy link
Collaborator

caguero commented Jun 6, 2025

Same functionality implemented in #637 , #642, #649, and #653. Thanks!

@caguero caguero closed this Jun 6, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in Core development Jun 6, 2025
This was referenced Jun 6, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caguero caguero caguero left review comments

Assignees

No one assigned

Labels

🏛️ ionic Gazebo Ionic

Projects

Core development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mjcarroll @caguero @azeey