Skip to content

Fix thread issue by adding check for invalid CLI combo #3135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix thread issue by adding check for invalid CLI combo #3135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cccbef7
add check to avoid thread issue
XINJIANGMO Oct 18, 2025
3c3c240
update error message
XINJIANGMO Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/cmd/sim_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,13 @@ int main(int argc, char** argv)

app.formatter(std::make_shared<GzFormatter>(&app));
CLI11_PARSE(app, argc, argv);

// check for invalid combination to avoid thread issue
if (!opt->file.empty() && !opt->playback.empty())
{
gzerr << "Both an SDF file and the playback flag (--playback) are specified. "
<< "Specify only one of these arguments." << std::endl;
return -1;
}
std::string parsedSdfFile;
if(!opt->launchServer && !opt->launchGui)
{
Expand Down
Loading