Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 17, 2025

🦟 Bug fix

Summary

Previously, the services immediately returned true after adding
the command to the pending commands queue which meant that
the return statuses did not reflect the success or failure of
the subsequent execution of the commands.

Needed for gazebosim/ros_gz#790

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #2999 done by [Mergify](https://mergify.com).

…xecuted command (#2999)

Previously, the services immediately returned true after adding
the command to the pending commands queue which meant that
the return statuses did not reflect the success or failure of
the subsequent execution of the commands.
---------

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
(cherry picked from commit 590e0f4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

1 participant