Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 16, 2025

🎉 New feature

Summary

System for assigning semantics to entities, such as models, by classifying them into categories and assigning them tags.

Reference:
https://github.com/ros-simulation/simulation_interfaces/blob/1.0.0/msg/EntityCategory.msg,
https://github.com/ros-simulation/simulation_interfaces/blob/1.0.0/msg/TagsFilter.msg

This system is meant to be attached to a <world>, but it parses parameters
found in entities such as models.

Example:

<model name="robot1">
  <gz:semantics>
    <category>ROBOT</category>
    <tag>mobile</tag>
    <tag>diff_drive</tag>
  </gz:semantics>
</model>

This is a nice to have for gazebosim/ros_gz#790 in order to implement the GetEntityInfo service as well as to allow filtering based on categories and tags in GetEntities

Test it

bin/INTEGRATION_entity_semantics_system 

Future work:

  • Service to set categories dynamically. This would be used to implement SetEntityInfo
  • Potentially consolidate this and the Label system which is used to add semantic labels to visuals for segmentation.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #3005 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from arjo129 as a code owner October 16, 2025 15:45
@mergify mergify bot added the conflicts label Oct 16, 2025
Copy link
Contributor Author

mergify bot commented Oct 16, 2025

Cherry-pick of a503633 has failed:

On branch mergify/bp/gz-sim8/pr-3005
Your branch is up to date with 'origin/gz-sim8'.

You are currently cherry-picking commit a503633e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   include/gz/sim/components/SemanticCategory.hh
	new file:   include/gz/sim/components/SemanticDescription.hh
	new file:   include/gz/sim/components/SemanticTags.hh
	modified:   src/systems/CMakeLists.txt
	new file:   src/systems/entity_semantics/CMakeLists.txt
	new file:   src/systems/entity_semantics/EntitySemantics.cc
	new file:   src/systems/entity_semantics/EntitySemantics.hh
	modified:   test/integration/CMakeLists.txt
	new file:   test/integration/entity_semantics_system.cc
	new file:   test/worlds/entity_semantics.sdf

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   BUILD.bazel

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

…3005)

System for assigning semantics to entities, such as models, by classifying them into categories and assigning them tags.

---------

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Co-authored-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit a503633)
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey force-pushed the mergify/bp/gz-sim8/pr-3005 branch from 1069a80 to d3eeb9d Compare October 17, 2025 14:41
@azeey azeey requested a review from iche033 October 17, 2025 14:42
@azeey
Copy link
Contributor

azeey commented Oct 17, 2025

Can I get a review since I fixed conflicts?

Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Oct 17, 2025
@azeey azeey merged commit 889eb18 into gz-sim8 Oct 17, 2025
9 checks passed
@azeey azeey deleted the mergify/bp/gz-sim8/pr-3005 branch October 17, 2025 17:47
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants