Refactor Transport service handlers UserCommands (backport #2996)
#3125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=80&v=4){kind=small}
|
Cherry-pick of bf68eae has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
9 tasks
* Refactor Transport service handlers This removes a lot of repetitive code where a service handler simply copies the message, creates and adds the associated command to a command queue. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Also refactor code for advertising services Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Add back missing function Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Update our usage of workerpools (#2995) In `SimulationRunner`, we initialize a worker pool but we never actually use it so it's pure overhead. In `ServerPrivate` we only use the worker pool if there are multiple simulation runners, so we can optimize for the most common use case of one runner. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Fix linter issues Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Fix typo Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> * Add missing constructor Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> --------- Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
azeey
force-pushed
the
mergify/bp/gz-sim8/pr-2996
branch
from
f5cc094 to
7edcccc
Compare
|
@iche033 canI get a review since I had to fix conflicts. |
iche033
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
This removes a lot of repetitive code where a service handler simply
copies the message, creates and adds the associated command to a command
queue.
This is a precursor to a follow-up PR that changes the service handlers to wait for the execution of the command before returning.
Note: It might be easier to review each commit separately.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.This is an automatic backport of pull request #2996 done by [Mergify](https://mergify.com).