Skip to content

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 10, 2025

🦟 Bug fix

Fixes part of of #626 .

Summary

The gz-sim-main contained the location of gui executable as an absolute location, that breaks in case gz-sim is compiled with the option GZ_ENABLE_RELOCATABLE_INSTALL and the install is moved after the installation.

See related PR #1968 .

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
@traversaro traversaro changed the title Fix relocatibility of gz-sim-main executable Fix relocatability of gz-sim-main executable Oct 10, 2025
Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough it works on windows.

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Oct 13, 2025
@azeey azeey merged commit dab822c into gazebosim:gz-sim10 Oct 13, 2025
13 of 14 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants