Skip to content

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 12, 2025

🦟 Bug fix

Summary

The lookup wheel slip system currently only searches the slip map file by checking path relative to the world file. This PR updates the file search logic to use common::findFile which is more reliable. It now searches for paths relative to the model sdf file (if plugin is added to a model in model.sdf) and world file, as well as URIs pointing to Fuel.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 requested a review from arjo129 as a code owner September 12, 2025 01:34
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Sep 12, 2025
@iche033 iche033 requested a review from jennuine September 12, 2025 01:35
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Sep 12, 2025
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
@iche033 iche033 merged commit 426c1a3 into gz-sim10 Sep 16, 2025
13 of 14 checks passed
@iche033 iche033 deleted the iche033/lookup_wheel_slip_findfile branch September 16, 2025 01:02
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants