Update our usage of workerpools (backport #2995) #2997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=80&v=4){kind=small}
9 tasks
|
@Mergifyio rebase |
In `SimulationRunner`, we initialize a worker pool but we never actually use it so it's pure overhead. In `ServerPrivate` we only use the worker pool if there are multiple simulation runners, so we can optimize for the most common use case of one runner. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> (cherry picked from commit 5ce62a8)
✅ Branch has been successfully rebased |
azeey
force-pushed
the
mergify/bp/gz-sim9/pr-2995
branch
from
1cda203 to
2d2d757
Compare
azeey
approved these changes
Aug 7, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gz-sim9 #2997 +/- ##
===========================================
- Coverage 69.09% 69.05% -0.05%
===========================================
Files 347 347
Lines 33951 33976 +25
===========================================
+ Hits 23460 23462 +2
- Misses 10491 10514 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
In
SimulationRunner, we initialize a worker pool but we never actually use it so it's pure overhead. InServerPrivatewe only use the worker pool if there are multiple simulation runners, so we can optimize for the most common use case of one runner.Checklist
codecheckpassed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.This is an automatic backport of pull request #2995 done by Mergify.